jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1118946985
##########
clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json:
##########
@@ -23,17 +23,39 @@
// Version 2 adds the support for new error code PRODUCER_FENCED.
//
// Version 3 enables flexible versions.
- "validVersions": "0-3",
+ //
+ // Version 4 adds VerifyOnly field to check if partitions are already in
transaction and adds support to batch multiple transactions.
+ // The AddPartitionsToTxnRequest version 4 API is added as part of KIP-890
and is still
+ // under developement. Hence, the API is not exposed by default by brokers
+ // unless explicitely enabled.
+ "latestVersionUnstable": true,
+ "validVersions": "0-4",
"flexibleVersions": "3+",
"fields": [
- { "name": "TransactionalId", "type": "string", "versions": "0+",
"entityType": "transactionalId",
- "about": "The transactional id corresponding to the transaction."},
- { "name": "ProducerId", "type": "int64", "versions": "0+", "entityType":
"producerId",
+ { "name": "Transactions", "type": "[]AddPartitionsToTxnTransaction",
"versions": "4+",
+ "about": "List of transactions to add partitions to.", "fields": [
+ { "name": "TransactionalId", "type": "string", "versions": "4+",
"mapKey": true, "entityType": "transactionalId",
+ "about": "The transactional id corresponding to the transaction." },
+ { "name": "ProducerId", "type": "int64", "versions": "4+", "entityType":
"producerId",
+ "about": "Current producer id in use by the transactional id." },
+ { "name": "ProducerEpoch", "type": "int16", "versions": "4+",
+ "about": "Current epoch associated with the producer id." },
+ { "name": "VerifyOnly", "type": "bool", "versions": "4+", "default":
false,
+ "about": "Boolean to signify if we want to check if the partition is
in the transaction rather than add it." },
+ { "name": "Topics", "type": "[]AddPartitionsToTxnTopic", "versions":
"4+",
+ "about": "The partitions to add to the transaction." }
+ ]},
+ { "name": "V3AndBelowTransactionalId", "type": "string", "versions":
"0-3", "entityType": "transactionalId",
Review Comment:
I had previous comments from @hachikuji and @guozhangwang that I should do
something like this to avoid confusion when setting the fields. I have seen
something similiar in other places but we didn't explicitly say the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
