C0urante commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1446878483
Hi @urbandan, thanks for clarifying the point about using `Schema` methods. Agreed that this would be helpful. I think we should try to keep validation of optionality if possible, and right now I don't see a case where this really breaks things. It seems like if we tweak `ConnectSchema::equals` to use the `Schema` interface methods, that should be sufficient to retain this validation without too much work? I'd rather not change the API surface here since that would require a KIP and manual action on the part of developers in order to address what is ultimately a bug in the current API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
