[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

[via GitHub]

philipnee commented on code in PR #13190:
URL: https://github.com/apache/kafka/pull/13190#discussion_r1119426667


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##########
@@ -3398,7 +3400,8 @@ public void 
testPrepareJoinAndRejoinAfterFailedRebalance() {
             client.respond(syncGroupResponse(partitions, Errors.NONE));
 
             // Join future should succeed but generation already cleared so 
result of join is false.
-            res = coordinator.joinGroupIfNeeded(time.timer(1));
+            coordinator.joinGroupIfNeeded(time.timer(0));

Review Comment:
   Similar here, the timer is expired upon IllegalGenerationException, the loop 
would continued in the original code, but now it would exit.  I guess we could 
try to poll for a bit longer, like 3ms instead of 0ms.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org