dajac commented on code in PR #13322: URL: https://github.com/apache/kafka/pull/13322#discussion_r1122808060
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -1267,6 +1314,24 @@ object KafkaConfig { .define(GroupInitialRebalanceDelayMsProp, INT, Defaults.GroupInitialRebalanceDelayMs, MEDIUM, GroupInitialRebalanceDelayMsDoc) .define(GroupMaxSizeProp, INT, Defaults.GroupMaxSize, atLeast(1), MEDIUM, GroupMaxSizeDoc) + /** New group coordinator configs */ + // All properties are kept internal until KIP-848 is released. + // This property meant to be here only during the development of KIP-848. It will + // be replaced by a metadata version before releasing it. + .defineInternal(NewGroupCoordinatorEnableProp, BOOLEAN, Defaults.NewGroupCoordinatorEnable, null, MEDIUM, NewGroupCoordinatorEnableDoc) + .defineInternal(GroupCoordinatorNumThreadsProp, INT, Defaults.GroupCoordinatorNumThreads, atLeast(1), MEDIUM, GroupCoordinatorNumThreadsDoc) + + /** Consumer groups configs */ + // All properties are kept internal until KIP-848 is released. + .defineInternal(ConsumerGroupSessionTimeoutMsProp, INT, Defaults.ConsumerGroupSessionTimeoutMs, atLeast(1), MEDIUM, ConsumerGroupSessionTimeoutMsDoc) Review Comment: They will be mainly used to ensure that the dynamic group configurations are within the defined boundaries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org