satishd commented on code in PR #13304:
URL: https://github.com/apache/kafka/pull/13304#discussion_r1124009466
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/FetchDataInfo.java:
##########
@@ -44,6 +45,28 @@ public FetchDataInfo(LogOffsetMetadata fetchOffsetMetadata,
this.abortedTransactions = abortedTransactions;
}
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+
+ FetchDataInfo that = (FetchDataInfo) o;
+
+ return firstEntryIncomplete != that.firstEntryIncomplete &&
+ Objects.equals(fetchOffsetMetadata, that.fetchOffsetMetadata)
&&
+ Objects.equals(records, that.records) &&
Review Comment:
+1, we can leave LogReadInfo not to implement equals/hashCode as it is not
really needed with the current usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
