[ 
https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696300#comment-17696300
 ] 

Adam commented on KAFKA-9234:
-----------------------------

I'd like to chip in: Since the last PR there has been an effort to implement a 
standardised library of nullability annotations: 
[JSpecify|https://jspecify.dev/docs/start-here]. It has the backing of [many 
big players in the JVM world|https://jspecify.dev/about#who-are-we], and I 
think it would be a good, forward-thinking decision if Kafka uses it.

While JSpecify hasn't had a 1.0 release, [they do say that it's ready for 
adoption|https://github.com/jspecify/jspecify/wiki/adoption]:

> As of 0.3, it's now extremely unlikely we would change any of the four 
> annotation interfaces in any incompatible way (that actually breaks your 
> build). So once your tools recognize them at all, then switching to them from 
> your current ones couldn't really hurt much.


> Consider using @Nullable and @Nonnull annotations
> -------------------------------------------------
>
>                 Key: KAFKA-9234
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9234
>             Project: Kafka
>          Issue Type: Improvement
>          Components: admin, clients, consumer, KafkaConnect, producer , 
> streams, streams-test-utils
>            Reporter: Matthias J. Sax
>            Assignee: Ganesh Sahu
>            Priority: Minor
>              Labels: beginner, newbie
>
> Java7 was dropped some time ago, and we might want to consider usein Java8 
> `@Nullable` and `@Nonnull` annotations for all public facing APIsĀ instead of 
> documenting it in JavaDocs only.
> This tickets should be broken down in a series of smaller PRs to keep the 
> scope of each PR contained, allowing for more effective reviews.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to