[GitHub] [kafka] dajac commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

[via GitHub]

dajac commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1125501983


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -1328,13 +1335,16 @@ RequestFuture<Void> sendOffsetCommitRequest(final 
Map<TopicPartition, OffsetAndM
             groupInstanceId = null;
         }
 
+        boolean canUseTopicIds = topicPartitionsWithoutTopicId == 0;

Review Comment:
   Should we add tests to cover this new logic?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org