jolshan commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126919357
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##########
@@ -62,6 +63,15 @@ private[group] class GroupCoordinatorAdapter(
private val time: Time
) extends org.apache.kafka.coordinator.group.GroupCoordinator {
+ override def consumerGroupHeartbeat(
+ context: RequestContext,
+ request: ConsumerGroupHeartbeatRequestData
+ ): CompletableFuture[ConsumerGroupHeartbeatResponseData] = {
+ FutureUtils.failedFuture(Errors.UNSUPPORTED_VERSION.exception(
+ s"The old group coordinator does not support
${ApiKeys.CONSUMER_GROUP_HEARTBEAT.name} API."
Review Comment:
Does this error message make sense? I thought we already failed for the "old
group coordinator" in KafkaApis, so wouldn't this run only if we were using the
new coordinator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
