philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127046532
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -83,12 +92,23 @@
private final Metrics metrics;
private final long defaultApiTimeoutMs;
+ public PrototypeAsyncConsumer(Properties properties,
+ Deserializer<K> keyDeserializer,
+ Deserializer<V> valueDeserializer) {
+ this(Utils.propsToMap(properties), keyDeserializer, valueDeserializer);
+ }
+
+ public PrototypeAsyncConsumer(final Map<String, Object> configs,
+ final Deserializer<K> keyDeser,
+ final Deserializer<V> valDeser) {
+ this(new ConsumerConfig(appendDeserializerToConfig(configs, keyDeser,
valDeser)), keyDeser,
+ valDeser);
+ }
@SuppressWarnings("unchecked")
- public PrototypeAsyncConsumer(final Time time,
- final ConsumerConfig config,
+ public PrototypeAsyncConsumer(final ConsumerConfig config,
final Deserializer<K> keyDeserializer,
final Deserializer<V> valueDeserializer) {
- this.time = time;
+ this.time = Time.SYSTEM;
Review Comment:
Thanks for spotting this. I think the unit test consumer is meant to be the
one below this. I think I should remove the time and make the constructor param
list the same as the current one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
