jsancio commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127237201
##########
raft/src/main/resources/common/message/QuorumStateData.json:
##########
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes clusterId field.
- "validVersions": "0-1",
+ "validVersions": "0",
"flexibleVersions": "0+",
"fields": [
+ {"name": "ClusterId", "type": "string", "versions": "0+"},
Review Comment:
This PR reverts a commit that made it to `trunk` but it is not included in
any of the releases. We need to revert this before we can release 3.5.
> I am confused, why not just have ClusterId and versions: "0" (no plus sign
at the end)?
I think that that may be part of the change. We still want to handle the
software downgrade since 3.4 and less assumes `clusterId` exists. In the
associated Jira I suggested creating a KIP for this improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
