guozhangwang commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1128780569
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -83,12 +92,23 @@
private final Metrics metrics;
private final long defaultApiTimeoutMs;
+ public PrototypeAsyncConsumer(Properties properties,
+ Deserializer<K> keyDeserializer,
+ Deserializer<V> valueDeserializer) {
+ this(Utils.propsToMap(properties), keyDeserializer, valueDeserializer);
+ }
+
+ public PrototypeAsyncConsumer(final Map<String, Object> configs,
+ final Deserializer<K> keyDeser,
+ final Deserializer<V> valDeser) {
+ this(new ConsumerConfig(appendDeserializerToConfig(configs, keyDeser,
valDeser)), keyDeser,
+ valDeser);
+ }
@SuppressWarnings("unchecked")
- public PrototypeAsyncConsumer(final Time time,
- final ConsumerConfig config,
+ public PrototypeAsyncConsumer(final ConsumerConfig config,
final Deserializer<K> keyDeserializer,
final Deserializer<V> valueDeserializer) {
- this.time = time;
+ this.time = Time.SYSTEM;
Review Comment:
I think as we go along with this, we would need to add this param back to
the constructor :) ANyways that's for future PRs then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
