guozhangwang commented on code in PR #13300:
URL: https://github.com/apache/kafka/pull/13300#discussion_r1128784726
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##########
@@ -457,15 +457,9 @@ public long restore(final Map<TaskId, Task> tasks) {
// small batches; this can be optimized in the future,
e.g. wait longer for larger batches.
final TaskId taskId =
changelogs.get(partition).stateManager.taskId();
try {
+ final Task task = tasks.get(taskId);
final ChangelogMetadata changelogMetadata =
changelogs.get(partition);
- final int restored = restoreChangelog(changelogMetadata);
- if (restored > 0 ||
changelogMetadata.state().equals(ChangelogState.COMPLETED)) {
- final Task task = tasks.get(taskId);
- if (task != null) {
Review Comment:
I pondered on the code and I think it should not be `null` ever? Please
correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
