chia7712 commented on code in PR #13348:
URL: https://github.com/apache/kafka/pull/13348#discussion_r1132455184
##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -113,7 +113,7 @@ void start(String[] args) throws IOException {
record = new ProducerRecord<>(topicName, payload);
long sendStartMs = System.currentTimeMillis();
- Callback cb = stats.nextCompletion(sendStartMs,
payload.length, stats);
+ cb = stats.nextCompletion(sendStartMs, payload.length, stats);
Review Comment:
Does it need to pass itself (`stats`) to nextCompletion? It seems to me
line#399 could be replaced by `new PerfCallback(this.iteration, start, bytes,
this);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
