cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134589780
##########
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##########
@@ -47,24 +46,44 @@ import scala.jdk.CollectionConverters._
*/
class ZkMigrationClient(zkClient: KafkaZkClient) extends MigrationClient with
Logging {
- override def getOrCreateMigrationRecoveryState(initialState:
ZkMigrationLeadershipState): ZkMigrationLeadershipState = {
- zkClient.createTopLevelPaths()
- zkClient.getOrCreateMigrationState(initialState)
+ @throws(classOf[MigrationClientException])
+ def wrapZkException[T](fn: => T): T = {
Review Comment:
Should we make it so that `wrapZkException(wrapZkException(e))` is the same
as `wrapZkException(e)`? In case we inadvertently end up nesting these somehow.
(Concretely I'm just saying: let's add a pass-through case for
MigrationClientAuthException / MigrationClientException)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
