[GitHub] [kafka] ijuma commented on a diff in pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

[via GitHub]

ijuma commented on code in PR #13390:
URL: https://github.com/apache/kafka/pull/13390#discussion_r1135739560


##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -182,7 +182,7 @@ class BrokerLifecycleManager(
    */
   private[server] val eventQueue = new KafkaEventQueue(time,
     logContext,
-    threadNamePrefix.getOrElse(""),
+    threadNamePrefix.getOrElse("") + "BrokerLifecycleManager" + nodeId,

Review Comment:
   Check the replica fetcher threads for an example where we do include source 
id in the thread name:
   
   > val threadName = 
s"${prefix}ReplicaFetcherThread-$fetcherId-${sourceBroker.id}-${fetcherPool.name}"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org