[GitHub] [kafka] mumrah commented on a diff in pull request #13384: KAFKA-14801 : Decode the sensitive configs and Zk and use encrypted records before writing them to KRaft log

[via GitHub]

mumrah commented on code in PR #13384:
URL: https://github.com/apache/kafka/pull/13384#discussion_r1135792879


##########
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##########
@@ -135,20 +138,34 @@ class ZkMigrationClient(zkClient: KafkaZkClient) extends 
MigrationClient with Lo
   }
 
   def migrateBrokerConfigs(recordConsumer: 
Consumer[util.List[ApiMessageAndVersion]]): Unit = {
-    val brokerEntities = zkClient.getAllEntitiesWithConfig(ConfigType.Broker)
     val batch = new util.ArrayList[ApiMessageAndVersion]()
+    val zkPasswordEncoder = kafkaConfig.passwordEncoderSecret match {

Review Comment:
   Can we pass in a PasswordEncoder to ZkMigrationClient rather than the full 
KafkaConfig? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org