mumrah commented on code in PR #13384:
URL: https://github.com/apache/kafka/pull/13384#discussion_r1136050391
##########
core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala:
##########
@@ -49,12 +51,25 @@ class ZkMigrationClientTest extends QuorumTestHarness {
private var migrationState: ZkMigrationLeadershipState = _
+ private val SECRET = "secret"
+
+ private val encoder: PasswordEncoder = {
+ val encoderProps = new Properties()
+ encoderProps.put(KafkaConfig.ZkConnectProp, "localhost:1234") // Get
around the config validation
+ encoderProps.put(KafkaConfig.PasswordEncoderSecretProp, SECRET) // Zk
secret to encrypt the
+ val encoderConfig = new KafkaConfig(encoderProps)
Review Comment:
Oh, I see -- we're getting the defaults for things like the cipher, key
length, etc. Let's keep this in, in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
