C0urante commented on code in PR #13386: URL: https://github.com/apache/kafka/pull/13386#discussion_r1136051929
########## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java: ########## @@ -216,7 +216,7 @@ public boolean commitOffsets() { this.committableOffsets = CommittableOffsets.EMPTY; } - if (committableOffsets.isEmpty()) { + if (offsetsToCommit.isEmpty()) { Review Comment: Haha, no worries! Considering I wrote this buggy logic in the first place I'm at least equally embarrassed here 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org