philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136454609
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ########## @@ -235,4 +373,105 @@ public void ack(final long currentTimeMs) { this.timer.update(currentTimeMs); } } + + private class FetchCommittedOffsetResponseHandler { Review Comment: It's 80% copy paste, a thing changed here: `retry(currentTimeMs);` is invoked upon RetriableExceptions. In the original code, the exception was raised and then retried until timeout. Here is the reference: https://github.com/apache/kafka/blob/d23ce20bdfbe5a9598523961cb7cf747ce4f52ef/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java#L1016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org