[GitHub] [kafka] C0urante commented on a diff in pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

[via GitHub]

C0urante commented on code in PR #13367:
URL: https://github.com/apache/kafka/pull/13367#discussion_r1138945859


##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTransactionsTest.java:
##########
@@ -45,7 +45,13 @@ public void startClusters() throws Exception {
         backupBrokerProps.put("transaction.state.log.min.isr", "1");
         producerProps.put(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "true");
         producerProps.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, 
"embedded-kafka-0");
-        super.startClusters();
+        startClusters(new HashMap<String, String>() {{
+            put("topics", "test-topic-.*, primary.test-topic-.*, 
backup.test-topic-.*");
+            put(PRIMARY_CLUSTER_ALIAS + "->" + BACKUP_CLUSTER_ALIAS + 
".enabled", "true");
+            put(BACKUP_CLUSTER_ALIAS + "->" + PRIMARY_CLUSTER_ALIAS + 
".enabled", "true");
+            // This is not necessary for this test, but is not tested 
elsewhere.
+            put("offset.lag.max", "0");

Review Comment:
   Don't we assume that the value of this property is non-zero in 
`MirrorConnectorsIntegrationBaseTest::waitForConsumerGroupFullSync`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org