philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1140429707
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ########## @@ -116,12 +114,21 @@ private void maybeAutoCommit(final long currentTimeMs) { log.debug("Auto-committing offsets {}", allConsumedOffsets); Review Comment: I feel this message is misleading - but in the new model, we batch the commits and send them out at the network client poll in the background thread. Maybe we word it as "enqueuing autocommit offsets {}", offsets ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org