[GitHub] [kafka] muralibasani commented on pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

Wed, 22 Mar 2023 11:16:06 -0700 


muralibasani commented on PR #13417:
URL: https://github.com/apache/kafka/pull/13417#issuecomment-1480046465

   > Thanks for the PR! We really want to avoid having tools depend on core. If 
there are methods from core that we want to use, we can move them to 
server-common.
   
   If tools module should not depend on core module, then the below imports 
should be moved to server-common
   
   import kafka.server.BrokerMetadataCheckpoint;
   import kafka.server.KafkaConfig;
   import kafka.server.MetaProperties;
   import kafka.server.RawMetaProperties;
   import kafka.tools.TerseFailure;
   
   this is a much bigger change then right ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to