hudeqi commented on code in PR #13446:
URL: https://github.com/apache/kafka/pull/13446#discussion_r1149945098
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -150,10 +156,30 @@ private void loadInitialConsumerGroups()
List<String> findConsumerGroups()
throws InterruptedException, ExecutionException {
- return listConsumerGroups().stream()
+ List<String> filterGroups = listConsumerGroups().stream()
.map(ConsumerGroupListing::groupId)
- .filter(this::shouldReplicate)
+ .filter(this::shouldReplicateByGroupFilter)
.collect(Collectors.toList());
+
+ List<String> checkpointGroups = new LinkedList<>();
+ List<String> irrelevantGroups = new LinkedList<>();
+
+ for (String group : filterGroups) {
+ Set<String> consumeTopics =
listConsumerGroupOffsets(group).keySet().stream()
+ .map(TopicPartition::topic)
+ .filter(this::shouldReplicateByTopicFilter)
+ .collect(Collectors.toSet());
+ // As long as a group consumes a topic configured in "topics", it
needs to sync for this group.
+ // Although the topic in "topics.exclude" may be consumed in this
group, this will be filtered out in the MirrorCheckpointTask.
Review Comment:
nice suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
