CalvinConfluent commented on code in PR #13408:
URL: https://github.com/apache/kafka/pull/13408#discussion_r1150881334
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1108,19 +1116,23 @@ private Errors validateAlterPartitionData(
return INVALID_UPDATE_VERSION;
}
- int[] newIsr = Replicas.toArray(partitionData.newIsr());
+
+ int[] newIsr = partitionData.newIsrWithEpochs().stream()
+ .map(brokerState ->
brokerState.brokerId()).collect(Collectors.toList())
+ .stream().mapToInt(Integer::intValue).toArray();
Review Comment:
You are right, it is not needed. Thanks for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
