guozhangwang commented on code in PR #13318: URL: https://github.com/apache/kafka/pull/13318#discussion_r1151218246
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ########## @@ -564,14 +566,26 @@ public void start() { // initialize the last commit as of now to prevent first commit happens immediately this.lastCommitMs = time.milliseconds(); + + log.info("StateUpdater thread started"); Review Comment: Yeah I agree with you that the start up log line is a duplicate; at the same time I found that the log line for shutting down the thread from the caller thread is still valuable in debugging. So I would remove this line while keeping the logger still at the class level for that log line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org