tinaselenge commented on PR #13373:
URL: https://github.com/apache/kafka/pull/13373#issuecomment-1489915598

   @C0urante No worries at all! I should have clarified it better. I think both 
logics work but perhaps the double logic in the targetConfig() is better since 
we can't rely solely on shouldReplicateSourceDefault as you said. I reverted 
that part but also added some comments explaining the conditions that we are 
filtering against, hopefully that makes sense. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to