showuon commented on code in PR #13456:
URL: https://github.com/apache/kafka/pull/13456#discussion_r1154178160
##########
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##########
@@ -148,6 +151,16 @@ private List<EpochEntry>
removeWhileMatching(Iterator<Map.Entry<Integer, EpochEn
return removedEpochs;
}
+ public LeaderEpochFileCache writeTo(LeaderEpochCheckpoint
leaderEpochCheckpoint) {
+ lock.writeLock().lock();
+ try {
+ leaderEpochCheckpoint.write(epochEntries());
Review Comment:
Good suggestion!
##########
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##########
@@ -148,6 +151,16 @@ private List<EpochEntry>
removeWhileMatching(Iterator<Map.Entry<Integer, EpochEn
return removedEpochs;
}
+ public LeaderEpochFileCache writeTo(LeaderEpochCheckpoint
leaderEpochCheckpoint) {
+ lock.writeLock().lock();
Review Comment:
Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
