vamossagar12 commented on code in PR #11433:
URL: https://github.com/apache/kafka/pull/11433#discussion_r1156231874
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -342,7 +342,18 @@ public void handleAssignment(final Map<TaskId,
Set<TopicPartition>> activeTasks,
maybeThrowTaskExceptions(taskCloseExceptions);
- createNewTasks(activeTasksToCreate, standbyTasksToCreate);
+ final Collection<Task> newActiveTasks =
createNewTasks(activeTasksToCreate, standbyTasksToCreate);
+ // If there are any transactions in flight and there are newly created
active tasks, commit the tasks
+ // to avoid potential long restoration times.
+ if (processingMode == EXACTLY_ONCE_V2 &&
threadProducer().transactionInFlight() && !newActiveTasks.isEmpty()) {
+ log.info("New active tasks were added and there is an inflight
transaction. Attempting to commit tasks.");
+ final int numCommitted =
commitTasksAndMaybeUpdateCommittableOffsets(newActiveTasks, new HashMap<>());
+ if (numCommitted == -1) {
Review Comment:
Thanks for this comment. IIUC, the suggestion is to move the
`rebalanceInProgress == true` from
`commitTasksAndMaybeUpdateCommittableOffsets` before creating new tasks and not
create any new tasks or try to commit them if there's a rebalance in progress?
Also, does the check in `commitTasksAndMaybeUpdateCommittableOffsets` still
remain? I see it is being called from a couple of other places as well like
`handleCorruption` and `commit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
