[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

[via GitHub]

jolshan commented on code in PR #13463:
URL: https://github.com/apache/kafka/pull/13463#discussion_r1156508649


##########
core/src/main/scala/kafka/common/InterBrokerSender.scala:
##########
@@ -45,10 +45,15 @@ abstract class InterBrokerSendThread(
 
   private val unsentRequests = new UnsentRequests
 
-  def generateRequests(): Iterable[RequestAndCompletionHandler]
+  private val requestManagers = new ArrayList[InterBrokerRequestManager]()

Review Comment:
   Yeah. I think I just start the thread first and then add the managers. I'm 
ok with either approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org