chia7712 commented on code in PR #13454: URL: https://github.com/apache/kafka/pull/13454#discussion_r1157333624
########## clients/src/main/java/org/apache/kafka/common/RecordReader.java: ########## @@ -14,10 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.kafka.tools; +package org.apache.kafka.common; Review Comment: > It's fine to use a separate module as you have. @ijuma thanks for this response. I prefer to use separate module. It won't bring complex dependency cycle ( core main/test -> tool main, tool test -> core main). Also, we can control the dependencies exposed to users without impacting the tools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
