cmccabe commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1160254440
########## checkstyle/import-control.xml: ########## @@ -48,6 +48,8 @@ <allow pkg="org.apache.kafka.common.utils" /> <allow pkg="org.apache.kafka.common.errors" exact-match="true" /> <allow pkg="org.apache.kafka.common.memory" /> + <!-- anyone can use persistent collection factories/non-library-specific wrappers --> + <allow pkg="org.apache.kafka.pcoll" exact-match="true" /> Review Comment: Well, "anyone" on the server side :) I don't think we want the kafka client to take this dependency. At least not yet, until we have a very clear use-case in mind. So with that in mind, sadly it might be better to add this "allow" to server-common, metadata, and core individually, rather than up here. (although that's slightly more work I realize) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
