ijuma commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1160986944
########## server-common/src/main/java/org/apache/kafka/pcoll/PHashMapWrapper.java: ########## @@ -69,41 +48,4 @@ default <T> Map<K, T> asJava(Function<V, T> valueMapping) { * @return a wrapped persistent map that differs from this one in that the given mapping is removed (if necessary) */ PHashMapWrapper<K, V> afterRemoving(K key); Review Comment: How about calling this `removed` and the other one `added`? That's the convention `scala` uses for non symbolic names and it seems to read a bit better than `after*`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org