dajac commented on code in PR #13536:
URL: https://github.com/apache/kafka/pull/13536#discussion_r1162500608


##########
group-coordinator/src/main/resources/common/message/ConsumerGroupMemberMetadataValue.json:
##########
@@ -34,6 +32,10 @@
       "about": "The list of subscribed topic names." },
     { "name": "SubscribedTopicRegex", "versions": "0+", "nullableVersions": 
"0+", "type": "string",
       "about": "The subscribed topic regular expression." },
+    { "name": "RebalanceTimeoutMs", "type": "int32", "versions": "0+", 
"default": -1,
+      "about": "The rebalance timeout" },
+    { "name": "ServerAssignor", "versions": "0+", "nullableVersions": "0+", 
"type": "string",
+      "about": "The server assignor to use; or null if not used." },

Review Comment:
   Missing fields.



##########
group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json:
##########
@@ -26,6 +26,8 @@
       "about": "The list of topic metadata.", "fields": [
       { "name": "TopicId", "versions": "0+", "type": "uuid",
         "about": "The topic id." },
+      { "name": "TopicName", "versions": "0+", "type": "string",
+        "about": "The topic name." },

Review Comment:
   Missing field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to