[GitHub] [kafka] mukkachaitanya commented on a diff in pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

[via GitHub]

mukkachaitanya commented on code in PR #13165:
URL: https://github.com/apache/kafka/pull/13165#discussion_r1162729307


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java:
##########
@@ -159,13 +143,7 @@ public ClassLoader compareAndSwapWithDelegatingLoader() {
      * @return A {@link LoaderSwap} handle which restores the prior 
classloader on {@link LoaderSwap#close()}.
      */
     public LoaderSwap withClassLoader(ClassLoader loader) {

Review Comment:
   minor suggestion. Given we swap with delegating loader in most of the places 
we changed, if it would useful to create a new function:
   ```java
   public LoaderSwap withDelegatingClassLoader() {
       return withClassLoader(delegatingLoader());
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org