gharris1727 commented on code in PR #13165:
URL: https://github.com/apache/kafka/pull/13165#discussion_r1163148455


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java:
##########
@@ -159,13 +143,7 @@ public ClassLoader compareAndSwapWithDelegatingLoader() {
      * @return A {@link LoaderSwap} handle which restores the prior 
classloader on {@link LoaderSwap#close()}.
      */
     public LoaderSwap withClassLoader(ClassLoader loader) {

Review Comment:
   I think I would be in favor of this change if we could eliminate or reduce 
the visibility of the delegatingLoader(), but there are a couple of non-trivial 
usages in tests which need a ClassLoader to use when constructing worker tasks. 
I don't think that two call-sites are enough to justify an extra method that 
makes the delegatingLoader into a public method that is only used in tests.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to