mjsax commented on code in PR #13496:
URL: https://github.com/apache/kafka/pull/13496#discussion_r1163228842
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableLeftJoin.java:
##########
@@ -159,11 +160,36 @@ public void init(final ProcessorContext<?, ?> context) {
@Override
public ValueAndTimestamp<VOut> get(final K key) {
- final ValueAndTimestamp<V1> valueAndTimestamp1 =
valueGetter1.get(key);
+ return computeJoin(key, valueGetter1::get, valueGetter2::get);
+ }
+
+ @Override
+ public ValueAndTimestamp<VOut> get(final K key, final long
asOfTimestamp) {
+ return computeJoin(
+ key,
+ k -> valueGetter1.get(k, asOfTimestamp),
+ k -> valueGetter2.get(k, asOfTimestamp));
Review Comment:
As above -- can we get rid of the indirection by calling `get(k,
asOfTimestamp)` and pass in the result into `computeJoin()`?
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableOuterJoin.java:
##########
@@ -154,9 +155,34 @@ public void init(final ProcessorContext<?, ?> context) {
@Override
public ValueAndTimestamp<VOut> get(final K key) {
+ return computeJoin(key, valueGetter1::get, valueGetter2::get);
+ }
+
+ @Override
+ public ValueAndTimestamp<VOut> get(final K key, final long
asOfTimestamp) {
+ return computeJoin(
+ key,
+ k -> valueGetter1.get(k, asOfTimestamp),
Review Comment:
As above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
