mjsax commented on code in PR #13477:
URL: https://github.com/apache/kafka/pull/13477#discussion_r1163702670


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##########
@@ -213,6 +212,31 @@ public <K, V> void send(final String topic,
                     keyClass,
                     valueClass),
                 exception);
+        } catch (final SerializationException exception) {

Review Comment:
   As pointed out during the KIP discussion, the new handler should also cover 
`ClassCastException` -- we only had a special catch-block for it, to get a 
better error message (we still want a good error message for this case, but we 
should also apply the handler and allow people to CONTINUE on a 
ClassCastException).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to