[ 
https://issues.apache.org/jira/browse/KAFKA-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445248#comment-16445248
 ] 

ASF GitHub Bot commented on KAFKA-6791:
---------------------------------------

huxihx opened a new pull request #4902: KAFKA-6791: Add CoordinatorNodeProvider 
in KafkaAdminClient
URL: https://github.com/apache/kafka/pull/4902
 
 
   KAFKA-6791: Add CoordinatorNodeProvider in KafkaAdminClient
   https://issues.apache.org/jira/browse/KAFKA-6791
   
   Add CoordinatorNodeProvider interface to support batch retrieval for group 
coordinators.
   
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add a CoordinatorNodeProvider in KafkaAdminClient
> -------------------------------------------------
>
>                 Key: KAFKA-6791
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6791
>             Project: Kafka
>          Issue Type: Improvement
>          Components: admin
>            Reporter: Guozhang Wang
>            Assignee: huxihx
>            Priority: Major
>
> As we add more and more coordinator-related requests to the admin client, we 
> can consider adding a CoordinatorNodeProvider to consolidate the common logic 
> pattern of finding the coordinator first, then send the corresponding request.
> Note that 1) with this provider interface it is almost not possible to batch 
> multiple groupIds per coordinator; there has to be a little more refactoring 
> to make it work. 2) for some requests like list consumers, group ids are not 
> known beforehand and hence we cannot use this provider as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to