mumrah commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1165614955


##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1142,9 +1190,20 @@ public ControllerResult<Void> generateRecordsAndResult() 
throws Exception {
                         "at metadata.version {} from {}.", 
bootstrapMetadata.records().size(),
                         bootstrapMetadata.metadataVersion(), 
bootstrapMetadata.source());
                 records.addAll(bootstrapMetadata.records());
-            } else if 
(featureControl.metadataVersion().equals(MetadataVersion.MINIMUM_KRAFT_VERSION))
 {
-                log.info("No metadata.version feature level record was found 
in the log. " +
+
+                // Bootstrap the initial ZK Migration record
+                featureControl.generateZkMigrationRecord(

Review Comment:
   Should we actually throw in this case? If someone bootstraps with MV 3.3 and 
the config enabled, they could upgrade the MV to 3.4+ and trigger the migration



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to