gharris1727 commented on PR #13548: URL: https://github.com/apache/kafka/pull/13548#issuecomment-1508814690
@ijuma I proposed this PR in the form I did because it restored a piece of code that was unintentionally changed. From an end user-perspective, the unintentional change was certainly bad, and reverting that change (in this PR) is certainly good. I'm sorry if the PR description did not make that clear, and I'll try to improve in the future. I have looked into the other changes and identified their causes to be something distinct from this regression: * DedicatedMirrorIntegrationTest has been flakey since before this regression was committed, and affects both testSingleNodeCluster and testMultiNodeCluster (as seen in your list of test failures). The regression that this PR addresses only ever caused a failure in the MultiNode case, as this code path is only active in multi node clusters. * ExactlyOnceSourceIntegrationTest appears to be failing due to an error from the kafka TransactionManager, and surfaces with a different error than this regression would cause. * I have not yet completed my investigation on the ForwardingAdmin test failures, but those are consistently failing (not flakey like this regression), started failing on a different PR than the one which introduced this regression, and only affect the forwarding admin tests. Note: 'forwarding admin' is a feature unrelated to 'connect herder request forwarding', despite sharing the word 'forwarding'. * AuthorizerTest is failing due to an NPE in a completely unrelated part of the code base. * The initializationError failures are due to 3 leaked threads, which would surprise me if it was related to this URL formatting logic. All in all, I saw an obvious typo in a previous PR, and opened a follow-up to fix it. I did not want to issue a "Fix every Connect test failure" as I think that would be harder to review and less modular if reverts needed to be made in the future. How would you approach this differently? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
