rondagostino commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1169270141
########## metadata/src/main/java/org/apache/kafka/image/TopicsImage.java: ########## @@ -76,8 +84,8 @@ public TopicImage getTopic(String name) { } public void write(ImageWriter writer, ImageWriterOptions options) { - for (TopicImage topicImage : topicsById.values()) { - topicImage.write(writer, options); + for (Map.Entry<Uuid, TopicImage> entry : topicsById.entrySet()) { + entry.getValue().write(writer, options); Review Comment: Yeah, it was in the Paguro implementation where `values()` was deprecated. We've moved away from that, but I left the code change in that stopped using the `values()` collection. This change doesn't harm anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org