lanshiqin commented on code in PR #13584: URL: https://github.com/apache/kafka/pull/13584#discussion_r1169715205
########## core/src/test/scala/unit/kafka/log/LogSegmentTest.scala: ########## @@ -65,6 +66,21 @@ class LogSegmentTest { Utils.delete(logDir) } + /** + * If the maximum offset beyond index, appended to the log section, it throws LogSegmentOffsetOverflowException + */ + @Test + def testAppendForLogSegmentOffsetOverflowException(): Unit = { + val seg = createSegment(0) + val largestOffset: Long = Integer.MAX_VALUE + 1 + val largestTimestamp: Long = Time.SYSTEM.milliseconds() Review Comment: Thanks, it really shouldn't be hardcoded directly here, I should use @ParameterizedTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org