Greg Harris created KAFKA-14919:
-----------------------------------
Summary: MM2 ForwardingAdmin tests should not conflate admin
operations
Key: KAFKA-14919
URL: https://issues.apache.org/jira/browse/KAFKA-14919
Project: Kafka
Issue Type: Test
Components: mirrormaker
Reporter: Greg Harris
The MirrorConnectorsWithCustomForwardingAdminIntegrationTest uses a special
implementation of ForwardingAdmin which records admin operations in a static
ConcurrentMap, which is then used to perform assertions.
This has the problem that one variable (allTopics) is used to perform
assertions for multiple different methods (adding topics, adding partitions,
and syncing configs), despite these operations each being tested separately.
This leads to the confusing behavior where each test appears to assert that a
particular operation has taken place, and instead asserts that at least one of
the operations has taken place. This allows a regression or timeout in one
operation to be hidden by the others, making the behavior of the tests much
less predictable.
These tests and/or the metadata store should be changed so that the tests are
isolated from one another, and actually perform the assertions that correspond
to their titles.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
