[
https://issues.apache.org/jira/browse/KAFKA-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449246#comment-16449246
]
ASF GitHub Bot commented on KAFKA-6795:
---------------------------------------
apovzner opened a new pull request #4918: KAFKA-6795: Added unit tests for
ReplicaAlterLogDirsThread
URL: https://github.com/apache/kafka/pull/4918
Added unit tests for ReplicaAlterLogDirsThread. Mostly focused on unit tests
for truncating logic.
While writing unit tests, found that PartitionFetchState constructor that
takes offset and delay ignores the delay parameter and uses 0 for the delay.
This constructor is used only by another constructor which passes delay = 0,
which luckily works. However, it is still good to fix that in case someone uses
that constructor with delay > 0.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add unit test for ReplicaAlterLogDirsThread
> -------------------------------------------
>
> Key: KAFKA-6795
> URL: https://issues.apache.org/jira/browse/KAFKA-6795
> Project: Kafka
> Issue Type: Improvement
> Reporter: Anna Povzner
> Assignee: Anna Povzner
> Priority: Major
>
> ReplicaAlterLogDirsThread was added as part of KIP-113 implementation, but
> there is no unit test.
> [~lindong] I assigned this to myself, since ideally I wanted to add unit
> tests for KAFKA-6361 related changes (KIP-279), but feel free to re-assign.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
