jolshan commented on code in PR #13579:
URL: https://github.com/apache/kafka/pull/13579#discussion_r1170681193
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -332,24 +331,45 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
debug(s"Returning ${Errors.INVALID_REQUEST} error code to client for
$transactionalId's AddPartitions request for verification")
responseCallback(AddPartitionsToTxnResponse.resultForTransaction(transactionalId,
partitions.map(_ -> Errors.INVALID_REQUEST).toMap.asJava))
} else {
- val result: ApiResult[(Int, TransactionMetadata)] =
getTransactionMetadata(transactionalId, producerId, producerEpoch, partitions)
-
+ val result: ApiResult[Map[TopicPartition, Errors]] =
+ txnManager.getTransactionState(transactionalId).flatMap {
+ case None => Left(Errors.INVALID_PRODUCER_ID_MAPPING)
+
+ case Some(epochAndMetadata) =>
+ val txnMetadata = epochAndMetadata.transactionMetadata
+
+ // generate the new transaction metadata with added partitions
+ txnMetadata.inLock {
+ if (txnMetadata.producerId != producerId) {
+ Left(Errors.INVALID_PRODUCER_ID_MAPPING)
+ } else if (txnMetadata.producerEpoch != producerEpoch) {
+ Left(Errors.PRODUCER_FENCED)
+ } else if (txnMetadata.pendingTransitionInProgress &&
!(txnMetadata.pendingState == Some(Ongoing) && txnMetadata.state == Ongoing)) {
+ // return a retriable exception to let the client backoff and
retry
+ Left(Errors.CONCURRENT_TRANSACTIONS)
Review Comment:
If we are pending commit or abort I don't know if it makes sense to verify
and allow the write to continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
