urbandan commented on code in PR #13594:
URL: https://github.com/apache/kafka/pull/13594#discussion_r1170921037
##########
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java:
##########
@@ -216,7 +219,12 @@ public void putTopicStateRetriableFailure() {
}).when(kafkaBasedLog).send(eq(key), valueCaptor.capture(),
any(Callback.class));
store.put(topicStatus);
- verify(kafkaBasedLog, times(2)).send(any(), any(), any());
+ try {
+ verify(kafkaBasedLog, times(2)).send(any(), any(), any());
Review Comment:
Did I introduce flakiness with KAFKA-14902?
If yes, I think this verify should be enhanced with a timeout
(times(2).timeout(...)) to allow the background thread to trigger the retry,
then you don't need to mock the executor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
