jeffkbkim commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171626106
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/VersionedMetadata.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.consumer; + +import java.nio.ByteBuffer; +import java.util.Objects; + +/** + * Immutable versioned metadata. + */ +public class VersionedMetadata { + public static final VersionedMetadata EMPTY = new VersionedMetadata((short) 0, ByteBuffer.allocate(0)); + + /** + * The version of the metadata encoded in {{@link VersionedMetadata#metadata}}. + */ + private final short version; + + /** + * The metadata bytes. + */ + private final ByteBuffer metadata; Review Comment: is this is what's stored by the consumer? ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/VersionedMetadata.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.consumer; + +import java.nio.ByteBuffer; +import java.util.Objects; + +/** + * Immutable versioned metadata. Review Comment: can we add more description on what is stored inside the metadata and how it's used? ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java: ########## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.consumer; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMemberValue; + +import java.nio.ByteBuffer; +import java.util.Collections; +import java.util.HashSet; +import java.util.Map; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * An immutable assignment for a member. + */ +public class Assignment { + public static final Assignment EMPTY = new Assignment( + (byte) 0, + Collections.emptyMap(), + VersionedMetadata.EMPTY + ); + + /** + * The error assigned to the member. + */ + private final byte error; Review Comment: what would be an example for an error? ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.consumer; + +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMemberMetadataValue; + +import java.nio.ByteBuffer; +import java.util.Objects; + +/** + * An immutable representation of a client side assignor within a consumer group member. + */ +public class ClientAssignor { + /** + * The name of the assignor. + */ + private final String name; + + /** + * The reason reported by the assignor. + */ + private final byte reason; + + /** + * The minimum metadata version supported by the assignor. + */ + private final short minimumVersion; + + /** + * The maximum metadata version supported by the assignor. + */ + private final short maximumVersion; + + /** + * The versioned metadata. + */ + private final VersionedMetadata metadata; Review Comment: what's an example of a metadata stored inside the client assignor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
