vcrfxia commented on code in PR #13522:
URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919015


##########
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##########
@@ -140,9 +163,9 @@ public void doJoinFromLeftThenDeleteLeftEntity() {
             final KeyValueStore<String, String> store = 
driver.getKeyValueStore("store");
 
             // Pre-populate the RHS records. This test is all about what 
happens when we add/remove LHS records
-            right.pipeInput("rhs1", "rhsValue1");
-            right.pipeInput("rhs2", "rhsValue2");
-            right.pipeInput("rhs3", "rhsValue3"); // this unreferenced FK 
won't show up in any results
+            right.pipeInput("rhs1", "rhsValue1", baseTimestamp);

Review Comment:
   I'll leave it as is for readability, since I believe auto-advance would be 
per-topic and the test behavior is clearer this way since it's explicit that 
records from the two input topics do not overlap/interleave in their timestamps.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to