vcrfxia commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1171926280
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java:
##########
@@ -118,10 +120,13 @@ public void process(final Record<KIn, VIn> record) {
newAgg = aggregator.apply(record.key(), record.value(), oldAgg);
- store.put(record.key(), newAgg, newTimestamp);
- tupleForwarder.maybeForward(
- record.withValue(new Change<>(newAgg, sendOldValues ? oldAgg :
null))
- .withTimestamp(newTimestamp));
+ final long putReturnCode = store.put(record.key(), newAgg,
newTimestamp);
+ // if not put to store, do not forward downstream either
+ if (putReturnCode != PUT_RETURN_CODE_NOT_PUT) {
+ tupleForwarder.maybeForward(
+ record.withValue(new Change<>(newAgg, sendOldValues ?
oldAgg : null, putReturnCode == PUT_RETURN_CODE_IS_LATEST))
Review Comment:
Same as above -- I'll simplify this if it's correct to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
