[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

[via GitHub]

cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173069848


##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -304,6 +338,13 @@ public void replay(FeatureLevelRecord record) {
         }
     }
 
+    public void replay(ZkMigrationStateRecord record) {
+        ZkMigrationState recordState = 
ZkMigrationState.of(record.zkMigrationState());
+        ZkMigrationState currentState = migrationControlState.get();
+        log.info("Transitioning ZK migration state from {} to {}", 
currentState, recordState);

Review Comment:
   Maybe we should not log this (or log at DEBUG only) if the current state and 
new state are the same?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org